TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Published 20 hours ago • verified publisher icon TileDB-Inc

Instrument the Tile class

Open davisp opened this issue 1 year ago • 1 comments

Instrument the Tile class

TYPE: IMPROVEMENT DESC: Instrument the Tile class

davisp avatar Feb 08 '24 00:02 davisp

This pull request has been linked to Shortcut Story #40495: Instrument Tile class for memory measurement.

shortcut-integration[bot] avatar Feb 08 '24 00:02 shortcut-integration[bot]

Screenshot 2024-02-20 at 6 16 29 PM

These are supper unscientific numbers of me just running the test suite on my laptop while watching Jeopardy, but near as I can tell there's no significant change before and after this PR.

I think most of the numbers are self explanatory, but I will point out that the "before" variable in these tests includes the commit to disable the four or so tests that break when we change the size of the Tile class. I doubt those extra tests on before would have affected timing very much but it felt wrong to give this PR even that slim advantage.

Let me know if you want me to look into anything more specific.

davisp avatar Feb 21 '24 00:02 davisp