2.8.2 fails to build ep_gcssdk

[okanisis]

Compiling latest release on Arch Linux and it fails trying to build ep_gcssdk.

It gives the error:

make[6]: warning: -j8 forced in submake: resetting jobserver mode.
In file included from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.cc:15:
/build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.h: In function ‘typename std::vector<T>::iterator benchmark::internal::AddPowers(std::vector<T>*, T, T, int)’:
/build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.h:22:30: error: ‘numeric_limits’ is not a member of ‘std’
   22 |   static const T kmax = std::numeric_limits<T>::max();
      |                              ^~~~~~~~~~~~~~
/build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.h:22:46: error: expected primary-expression before ‘>’ token
   22 |   static const T kmax = std::numeric_limits<T>::max();
      |                                              ^
/build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.h:22:49: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   22 |   static const T kmax = std::numeric_limits<T>::max();
      |                                                 ^~~
      |                                                 std::max
In file included from /usr/include/c++/11.2.0/algorithm:62,
                 from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/include/benchmark/benchmark.h:172,
                 from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/internal_macros.h:4,
                 from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/check.h:8,
                 from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.h:6,
                 from /build/tiledb/src/tiledb-2.8.2/build/externals/src/ep_gcssdk/cmake-out/external/benchmark/src/benchmark-project/src/benchmark_register.cc:15:
/usr/include/c++/11.2.0/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
make[8]: *** [src/CMakeFiles/benchmark.dir/build.make:118: src/CMakeFiles/benchmark.dir/benchmark_register.cc.o] Error 1
make[8]: *** Waiting for unfinished jobs....
make[7]: *** [CMakeFiles/Makefile2:100: src/CMakeFiles/benchmark.dir/all] Error 2
make[6]: *** [Makefile:136: all] Error 2

[ihnorton]

Hi @okanisis, what is the GCC version here?

[okanisis]

Hi @okanisis, what is the GCC version here?

It's gcc 11.2.0

[ihnorton]

Thanks - it looks like we will need to update the GCS SDK version in order to resolve this. I don't have an ETA right now, but we will dig in further and evaluate.

[Amirox17]

Hi @ihnorton, Any updates on the manner ? I'm getting the same issue when building 2.15 & older versions (2.14, 2.11 ....) - is gcs not supported anymore by TDB ?

[ihnorton]

Hi @Amirox17, we're doing the update in this PR, which I expect to merge this week: https://github.com/TileDB-Inc/TileDB/pull/3920

[Amirox17]

Thanks ! Looking forward !

[KiterLuc]

This should be fixed. Please re-open if it's not the case.