debug build unit test failure "ChunkedBuffer: Test shallow copy"

[d-hoke]

seen with commit 1282754 windows 10, Debug build, vs2017, 8 logical cores

The routine ChunkedBuffer ChunkedBuffer::shallow_copy() const {} in chunked_buffer.cc appears dependent on RVO to actually produce a shallow copy. With vs2017 in debug build, apparently RVO is not performed and the copy constructor for ChunkedBuffer is invoked from the

return copy;

at end of shallow_copy(), which directly invokes a deep_copy(), thus failing to be shallow.

reported failure

ChunkedBuffer: Test shallow copy
-------------------------------------------------------------------------------
E:\dev\tiledb\gh.tiledb.27.11.2020.git\test\src\unit-ChunkedBuffer.cc(765)
...............................................................................

E:\dev\tiledb\gh.tiledb.27.11.2020.git\test\src\unit-ChunkedBuffer.cc(817): FAILED:
  CHECK( chunked_buffer1_chunk_0 == chunked_buffer2_chunk_0 )
with expansion:
  0x0000027de1f5c060 == 0x0000027de257b530

[joe-maley]

@d-hoke

Good catch, thanks! I appreciate you opening these issues. We're always interested in engaging with active users/contributors to learn more about how they're using TileDB. If you'd like to chat, please send me an email to [email protected].

[KiterLuc]

ChunkedBuffer doesn't exist anymore.