TileDB-Py icon indicating copy to clipboard operation
TileDB-Py copied to clipboard

Update clang-format to 18

Open kounelisagis opened this issue 1 year ago • 1 comments

Currently, clang-format runs only on linux in a non-standard way: https://github.com/TileDB-Inc/TileDB-Py/blob/d447f12f500884cdd01733d852a1bc7803a8de9e/.github/workflows/format.yml#L15-L19

It should be better to use the pypi edition of it: https://pypi.org/project/clang-format/ which also provides pre-commit hook and it's system agnostic.


[sc-43783]

kounelisagis avatar Aug 16 '24 11:08 kounelisagis

@kounelisagis @ihnorton can we perhaps have a discussion about syncing clang-format version changes across packages?

For those of us doing development on a single repo, whatever version the repo is using, the developer can easily switch to.

For those of us doing multi-repo development -- and given that clang-format 14 disagrees with clang-format 18 -- we could have a situation where a given developer needs to switch clang-format versions back & forth when pushing PRs to different packages.

I'm aware of personally:

  • Core
  • TileDB-Py
  • TileDB-SOMA
  • TileDB-VCF
  • and perhaps others

I'm all in favor of moving "into the future" -- just flagging the opportunity for a synchronize (unless there is such underway and I've missed it).

johnkerl avatar Aug 17 '24 14:08 johnkerl

Rebased onto the main branch

kounelisagis avatar Feb 04 '25 22:02 kounelisagis