TileDB-Py icon indicating copy to clipboard operation
TileDB-Py copied to clipboard

[2.12] Add Support for `delete` Mode

Open ihnorton opened this issue 3 years ago • 1 comments

ihnorton avatar Aug 31 '22 15:08 ihnorton

One thing I am unsure about with the delete API design as I have it is you need to use __getitem__ in order to actually submit the query:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1"))[:]

Whereas this won't do anything and just creates a PyQuery object but would make more sense for deletes because we aren't actually getting anything back:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1")

nguyenv avatar Sep 23 '22 20:09 nguyenv

One thing I am unsure about with the delete API design as I have it is you need to use __getitem__ in order to actually submit the query:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1"))[:]

Whereas this won't do anything and just creates a PyQuery object but would make more sense for deletes because we aren't actually getting anything back:

with tiledb.open(path, "d", timestamp=3) as A:
    A.query(attr_cond=tiledb.QueryCondition("ints == 1")

I've modified this to make it so that the latter does do a delete without needing to apply the regular indexer.

nguyenv avatar Oct 21 '22 17:10 nguyenv

Replaced by #1388

ihnorton avatar Nov 03 '23 16:11 ihnorton