TileDB-Py icon indicating copy to clipboard operation
TileDB-Py copied to clipboard

Update Minimum Supported macOS Version to 11.0

Open nguyenv opened this issue 2 years ago • 2 comments

  • Microsoft is currently issuing brownouts for macOS 10.15. Support in GitHub Actions will cease at the end of August and in Azure at the end of September. Our minimum supported version will need to be bumped to macOS 11 Big Sur.

nguyenv avatar Aug 10 '22 15:08 nguyenv

[sc-19634]

nguyenv avatar Aug 10 '22 15:08 nguyenv

This pull request has been linked to Shortcut Story #19634: Deprecate Support For macOS 10.15.

Will need to look at issues with building wheels with macOS 11.0 upgrade:

ERROR: tiledb-0.1.dev1-cpxx-cpxx-macosx_11_0_x86_64.whl is not a supported wheel on this platform

nguyenv avatar Aug 15 '22 18:08 nguyenv

Microsoft has just announced that deprecation of 10.15 is being pushed to December 1st: https://github.com/actions/runner-images/issues/5583#issuecomment-1219501124. We should still make sure that this gets updated sooner rather than later.

nguyenv avatar Aug 18 '22 20:08 nguyenv

We now build wheels on macOS 11 as of https://github.com/TileDB-Inc/TileDB-Py/pull/1300. However, we still need to migrate CI to macOS 11.

The culprit lines are: https://github.com/TileDB-Inc/TileDB-Py/blob/dev/.github/workflows/ci.yml#L58-L65

More specifically 'pip install' seems to be trying to install a wheel that has a incorrect TileDB-Py version as noted above. This issue was not reproducible on a macOS 11 EC2 instance, so there might be something incorrect about how the workflows are set up.

nguyenv avatar Aug 27 '22 14:08 nguyenv

https://github.com/TileDB-Inc/TileDB-Py/actions/runs/3054432721/jobs/4926319975#step:6:48

https://github.com/actions/runner-images/issues/2187

https://github.com/actions/setup-python/issues/279 https://github.com/pypa/pip/issues/10670

Wheels built on Microsoft's macOS-11 runners are not actually compatible with itself seemingly due to Intel vs M1 usage and the fact Microsoft does not yet support M1 (not sure I completely understand)? I think this means we still need to upgrade the runners to macOS-11 but keep MACOSX_DEPLOYMENT_TARGET at 10.15.

nguyenv avatar Sep 14 '22 18:09 nguyenv