Sergei Tigrov

Table foreign keys load two times as arrays and as objects

5

Current implementation loads table foreign keys two times as arrays and as objects. PostgreSQL https://github.com/yiisoft/db-pgsql/tree/535975396d865da6cb15ed7bee5648c27a9b7360/src/Schema.php#L499 as arrays https://github.com/yiisoft/db-pgsql/tree/535975396d865da6cb15ed7bee5648c27a9b7360/src/Schema.php#L894 as objects MySQL https://github.com/yiisoft/db-mysql/blob/4dd4e13502a0f047627c398854fc733a41054370/src/Schema.php#L265 as arrays https://github.com/yiisoft/db-mysql/blob/4dd4e13502a0f047627c398854fc733a41054370/src/Schema.php#L618 as objects SQLite https://github.com/yiisoft/db-sqlite/blob/b172ec9c11f31a5618a80e8cc6e3b298f423eb26/src/Schema.php#L381 as...

Support DateTime instances

2

Some comments are left for review and will be removed after. `ColumnSchema::dateTimeFormat()` and `ColumnSchema::$dateTimeFormat` can be removed, in this case it will be necessary to determine the format from `ColumnSchema`...

What is the difference between `InvalidArgumentException` and `InvalidParamException`?

3

What is the difference between `InvalidArgumentException` and `InvalidParamException`? Should be one replaced with another and then removed? | Q | A | ---------------- | --- | Version | 1.1.0 |...

Summary for `ActiveRecord`

4

- [x] 1. Rename `BaseActiveRecord` class to `AbstractActiveRecord` - [x] 2. Make `AbstractActiveRecord` class implements only `ActiveRecordInterface` - [x] 3. Move other interfaces to `ActiveRecord` class - [x] 4. Move...

* `ActiveRecordInterface::getOldPrimaryKey(bool $asArray = false)` split to * `getOldPrimaryKey(): mixed` equals to `ActiveRecordInterface::getOldPrimaryKey(false)` * `getOldPrimaryKeys(): array` equals to `ActiveRecordInterface::getOldPrimaryKey(true)` * `ActiveRecordInterface::getPrimaryKey(bool $asArray = false)` split to * `getPrimaryKey(): mixed` equals...

`ActiveQuery` class should not extend `Yiisoft\Db\Query\Query`

1

`Yiisoft\Db\Query\Query` class can be extended in each supported DBMS. E.g. we can have `Yiisoft\Db\Mssql\Query` which extends `Yiisoft\Db\Query\Query`. In this case `ActiveQuery` will not know about the extensions in `Yiisoft\Db\Mssql\Query`. ###...

Fix extensibility issue

2

| Q | A | ------------- | --- | Is bugfix? | ✔️ | New feature? | ❌ | Breaks BC? | ❌ | Fixed issues | #55, #18

Related with yiisoft/db#729

Support DateTime instances

1

| Q | A | ------------- | --- | Is bugfix? | ❌ | New feature? | ✔️ | Breaks BC? | ✔️ | Fixed issues | [#725](https://github.com/yiisoft/db/issues/725)