Thijs Schreijer comments

Results 444 comments of


                                            Thijs Schreijer

Register callback functions when peers are marked down or up

accidentally ran into this PR while browsing the lib. I think it is worth noting that the library will only have a single worker do the healthchecks. Hence the callbacks...

the TCP client does not do any retries ('retrans' option)

ping @agentzh

Clarify the location and role of errcode and errstr in the return value for (tcp_)query.

@thibaultcha this PR is correct and helpful

feature: allow socket override

@thibaultcha mind having a look?

feature: allow socket override

the CI failures seem to be unrelated?

feature: allow socket override

ping @thibaultcha

feature: allow socket override

@thibaultcha @spacewander just ran into this old PR. Rebased it. Can we either merge it, or close it if there is no intention to merge it?

fix: include server_name in the connection pool

the default might reuse a connection opened with different properties, and hence is a security issue

fix: include server_name in the connection pool

probably this isn't even enough, see https://github.com/ledgetech/lua-resty-http/pull/206/files#diff-654e4e7b65177f9d0e6eb1d4b1c259dbR133-R143

[bug] semaphore not released on exit/premature

If, in the above example, I change: ```lua sema:post(1000) ``` into ```lua sema:post(1000) ngx.timer.at(0, function() ngx.log(ngx.WARN,"please ignore") end) ``` then it works as expected. ping @javierguerragiraldez