nuxt3-magento-sdk-storefront icon indicating copy to clipboard operation
nuxt3-magento-sdk-storefront copied to clipboard

Add Breadcrumbs

Open rohrig opened this issue 2 years ago • 3 comments
trafficstars

rohrig avatar Jun 22 '23 15:06 rohrig

@rohrig for this task I've following questions

  • Do we need to extend sdk and add new query for bread crumbs?
  • Why do we need to add it in default layout, other pages like cart, checkout etc. I think we can add it in apps/nuxt/pages/[...slug].vue. What do you say?

faizanarif121 avatar Jun 25 '23 17:06 faizanarif121

@faizanarif121 Those are very valid points.

It looks like this is perhaps not a good first issue after all. 😁

I had a look at V2 and the solution there is not exactly trivial. You can check there for inspiration, but we are by no means bound to anything there. If you find a cleaner, better way to do it, that's great.

It looks like there is a separate solution for the category page and the product pages. I'll adjust the issue description accordingly.

If you're up for it. You could plan a solution. I'm happy to support you in any way I can. We can continue the discussion here or if you like you could create an RFC in the discussions tab above with your proposed solution so others can give feedback before you code the solution. This is not required, but it might be a good idea. If you want to just dig in and code the solution, I'm happy with that, too.

rohrig avatar Jun 25 '23 20:06 rohrig

sure @rohrig. I've holidays starting from tomorrow, I'll look into it once I'm back.

faizanarif121 avatar Jun 27 '23 19:06 faizanarif121