Thunder

Results 18 comments of Thunder

> Imo "or not" is redundant, but it's your choice if you want to include it. Some docs have it, some have "whether [property info here] or not", some don't...

> I'm going to hold off on merging this (for 5.3.0-rc.1) because it isn't quite a bug fix, although it isn't really an addition either. ok

aaaaaaaaaaaaaaaaa

> I'm not certain the eventargs renaming is necessary, seeing as it's in an event in the Events.Handlers.Scp914 class already. But this being a breaking change means it won't be...

I can imagine the "trigger multiple times" would be a problem for plugins such as discord game logging plugins, which would send a log multiple times.

> Idk if devs will accept this, it's better do a transpiler for the patch. iirc they accept non-transpiler patches and convert them to transpilers later on. may be wrong...

ReceivingPreferences transpiler needs fixed to use FirearmType

It is very much necessary

> these props also exists in `Player` class, so need to fix the duplicate Oh right, I thought they were removed. Forgot to check lol