Ceedling icon indicating copy to clipboard operation
Ceedling copied to clipboard

Fixed #783 cmock of the wrong file is generated

Open informatimago opened this issue 2 years ago • 1 comments

Do not add subdirectories of configured paths to the list of all headers,
since the user may use ** himself, and may order the paths to include
specific files.

Added comment mentioning path of source file to generated files.

informatimago avatar Jun 26 '23 12:06 informatimago

We noticed the same issue (wrong header being included, even though its path was not being included, its parent path was) on ceedling 0.32. ceedling 0.31 does not have this issue, seems a regression.

Well, it was somewhat "random", before I fixed the order by sorting the results of Dir.glob.

informatimago avatar Aug 11 '23 07:08 informatimago

I am supposing this behavior has long since been resolved by other fixes? Directory listing results order is now enforced by explicit sorting, and a whole lot of patching and workarounds have been applied to overcome Rake::FileList shortcomings (FYI—to be entirely replaced in a future release).

mkarlesky avatar Jun 13 '24 14:06 mkarlesky

Since active maintenance of 0.31 is coming to an end with the impending release of a significant new version of Ceedling, I'm going to close this PR. I suspect this bug is fixed in the next major version. If not, it will be when we tackle a holistic approach to managing search paths and file finding. At present Ceedling is using some educated guesses in certain cases as it was built up from some simplistic assumptions and conventions that did not take into account edge cases like header files with the same name differentiated by directory paths.

If the problem persists in the coming Ceedling 1.0.0 (still known as 0.32 here and there), please open a new Github issues with details.

mkarlesky avatar Jun 25 '24 14:06 mkarlesky