Ceedling icon indicating copy to clipboard operation
Ceedling copied to clipboard

Add support for dashes in filenames to test context extractor

Open bidds95 opened this issue 7 months ago • 3 comments

It looks like commit #b75b523 may have inadvertently broken support for dashes in filenames. A small change to the regex pattern in _extract_includes() fixes the issue.

I haven't found any open issues or anything to suggest support was dropped (Issue #439 suggests it was supported in release 1.0.0). Let me know if I've missed something.

I've tweaked an existing unit test to cover dashes in filenames.

bidds95 avatar May 12 '25 08:05 bidds95

Isn't this already fixed in https://github.com/ThrowTheSwitch/Ceedling/commit/d3c0bffd8a2daef028c9803ccd6e7e107fc97f15 (issue https://github.com/ThrowTheSwitch/Ceedling/issues/780)?

swaldhoer avatar May 13 '25 23:05 swaldhoer

Isn't this already fixed in d3c0bff (issue #780)?

Hi @swaldhoer, I think these might be different issues. This issue affects the include directive whereas issue #780 only affects test filenames. For example, I spotted this when a mock wasn't being generated for a file which included dashes in the name, but I think it affects more than just mock generation.

bidds95 avatar May 14 '25 06:05 bidds95

Ah sorry yes I think you are correct

swaldhoer avatar May 19 '25 15:05 swaldhoer