thriftpy2 icon indicating copy to clipboard operation
thriftpy2 copied to clipboard

try to fix issue #172 when system locale not set

Open truebit opened this issue 4 years ago • 7 comments

try to fix #172

truebit avatar May 13 '21 10:05 truebit

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.04 :warning:

Comparison is base (220aabf) 84.31% compared to head (b6f493a) 84.28%.

:exclamation: Current head b6f493a differs from pull request most recent head b74a8cd. Consider uploading reports for the commit b74a8cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   84.31%   84.28%   -0.04%     
==========================================
  Files          44       44              
  Lines        4164     4168       +4     
==========================================
+ Hits         3511     3513       +2     
- Misses        653      655       +2     
Impacted Files Coverage Δ
thriftpy2/parser/parser.py 95.24% <57.14%> (-0.37%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 13 '21 10:05 codecov[bot]

Thank you, please fix the CI error

ethe avatar May 14 '21 03:05 ethe

I have fixed Python2 test error. But the python 3.4 one seems environment related:"ImportError: No module named 'typing'".

truebit avatar May 14 '21 16:05 truebit

The py3.4 issue was addressed in #175. You could firstly approve #175 and then approve this PR.

truebit avatar May 17 '21 03:05 truebit

@ethe Could you please review this PR? this problem affects those machine which did not set LANG, especially in docker.

truebit avatar Jan 07 '22 03:01 truebit

@ethe It seems Travis CI changed Open Source credits point assignment rules: "Owner Thriftpy does not have enough credits.", so all the ci checks failed to be executed. Maybe you should check ci settings.

Below is copied from FAQ of TravisCI:

Where can I check my credit balance?

You can check your credit balance by going to Settings -> Plan usage -> Credits. You can find a bar representing the subscribed credits pool and remaining credits. You can check the status of your Open Source Software (OSS) credits as well.

What if I am building open source? Each of the Travis CI Plans contains an amount of special OSS credits per month assigned to run builds only on public repositories. To find out more about it please contact the Travis CI support team. In the email please include:

Your account name and your VCS provider (like travis-ci.com/github/[your account name] ) How many credits (build minutes) you’d like to request (should your run out of credits again you can repeat the process to request more or to discuss a renewable amount)

truebit avatar Jan 10 '22 11:01 truebit

Ok, I will try to fix CI or check it manually, this looks good to me.

ethe avatar Jan 10 '22 12:01 ethe

I have no idea how CI is failed image

ethe avatar May 26 '23 03:05 ethe