Ocelot icon indicating copy to clipboard operation
Ocelot copied to clipboard

FluentValidation 10.0+ breaking change

Open ahuang321 opened this issue 3 years ago • 7 comments

On a project where FluentValidation 10 was forced down. Per docs this included breaking changes:

https://docs.fluentvalidation.net/en/latest/upgrading-to-10.html

Currently running Ocelot 17.0 .NET Core 5.0, which now returns this error on startup:

Method not found: 'System.Collections.Generic.IList`1<FluentValidation.Results.ValidationFailure> FluentValidation.Results.ValidationResult.get_Errors()

ahuang321 avatar Apr 29 '21 13:04 ahuang321

Had a similar issue on a project of mine, not with Ocelot itself, but with another dependency that was also using FluentValidation.

I was trying to use Fluent Validation 10.x, while my dependency used 9.x, ended up having to downgrade fluent on my side.

Maybe it can solve your issue until they upgrade it here.

raschmitt avatar Jun 09 '21 23:06 raschmitt

Could you please update FluentValidation to the latest version?

Gurgen avatar Sep 24 '21 08:09 Gurgen

Same issue today. Latest Ocelot and FluentValidation. FluentValidation was added to a core component shared across services. Even though the ocelot service doesn't use it, it's still causing an issue.

Tsukasa42 avatar Oct 18 '21 17:10 Tsukasa42

Is the issue resolved? I also cannot use FluentValidation <= 10.3.4 because of other libraries and theit dependencies and I don't know how can I use Ocelot v17.0.0 now? Any tips?

PatryxCShark avatar Nov 15 '21 14:11 PatryxCShark

Any update ?

teomane avatar Dec 02 '21 08:12 teomane

any update on this?

codehunter13 avatar Mar 21 '22 10:03 codehunter13

Faced the same issue - got it resolved by explicitely installing FluentValidation 11.0.2 together with Ocelot 18.0.0

vaclavholusa avatar May 30 '22 10:05 vaclavholusa

Hi @ahuang321 Thanks for reporting 2 years ago! :smile_cat:

@raschmitt @Gurgen @Tsukasa42 @PatryxCShark @teomane @codehunter13 @vaclavholusa The FluentValidation package was updated in 19.0.2 release. The current version of the package is 11.5.2 Please update your Ocelot package reference to 19.0.2 version please! And consider upgrading the project to .NET 7 plz!

I'm going to close the issue...

raman-m avatar May 13 '23 13:05 raman-m