ThreeMammals
Add info about MMLib.SwaggerForOcelot to notsupported.rst
Hi,
first of all, thank you for this great project and for actively taking care of it.
Many people are still looking for a way to aggregate their microservice documentation directly on the API Gateway. This is what my MMLib.SwaggerForOcelot project provides. I know it doesn't cover all scenarios like people use Ocelot, but a lot of it. Many people use this package.
I prepared this PR so that people who are looking for a way to do it can find a solution faster. I will be happy if it gets into this documentation. However, I will understand if you reject this PR.
Thank you again.
Hi,
some acceptance test failed. But I'm not sure how this can be caused by a change in the documentation. I tried to find a connection, but in vain.
Burgyn commented on Dec 29, 2022
I will check the PR!
Tom has no intention to develop this product because he was greatly inspired by Microsoft's YARP gateway in 2020. 🤣 Also, Tom has moved to another tech stack of Node.js and TypeScript. So, he has no much interest in leading his .NET project anymore. This is the truth! And reality...
Burgyn commented on Feb 5, 2021:
Many people are still looking for a way to aggregate their microservice documentation directly on the API Gateway. This is what my MMLib.SwaggerForOcelot project provides. I know it doesn't cover all scenarios like people use Ocelot, but a lot of it. Many people use this package.
Wow! I am impressed! So, cool package you've designed and built! 🥇
Burgyn/MMLib.SwaggerForOcelot | MMLib.SwaggerForOcelot.csproj
It uses Ocelot v18 which is .NET 6 release. Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19? We have made .NET 7 release on April 23.
I prepared this PR so that people who are looking for a way to do it can find a solution faster. I will be happy if it gets into this documentation. However, I will understand if you reject this PR.
We will not reject your request! You just want to update the Not Supported section in docs.
Now I need to think about the right way we could move on... Well...
- 1st, I don't like current Not Supported docs section. It is not structured well. It should be reviewed at least.
- 2nd, We have no sample web app for current instructions to enable Swagger being written by Tom. We could add a sample with default Swagger settings
- 3rd, your PR could have a new sample web app with the reference to your MMLib.SwaggerForOcelot package.
I believe, we need to convert this simple docs updating PR to real feature request, and work more on a sample. And sure we will update docs.
So, What about converting your PR to a feature request with more advanced description?
Any ideas are welcome!
Hi @raman-m,
thanks for your replays.
I will check the PR! Tom has no intention to develop this product because he was greatly inspired by Microsoft's [YARP]> (https://github.com/microsoft/reverse-proxy) gateway in 2020. 🤣 Also, Tom has moved to another tech stack of Node.js and TypeScript. So, he has no much interest in leading his .NET project anymore. This is the truth! And reality...
Yes I know about that. I understand his decision and I fully respect it.
Wow! I am impressed! So, cool package you've designed and built! 🥇
Thanks, it came out of necessity and people started using it 🙂.
It uses Ocelot v18 which is .NET 6 release. Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19? We have made .NET 7 release on April 23.
Yes, I'm updating my project. I don't actively follow it, I only do it when someone notifies me. I will do it in the next few days.
So, What about converting your PR to a feature request with more advanced description?
It makes sense. I'll take a look at it and try to make a meaningful demo. It won't be right away though, I expect a couple of weeks before I get around to it.
Hi @raman-m
It uses Ocelot v18 which is .NET 6 release. Do you have a plan to upgrade your project to .NET 7 and reuse Ocelot v19? We have made .NET 7 release on April 23.
New version of my package with Ocelot 19 and .NET 7 was released.
New version of my package with Ocelot 19 and .NET 7 was released.
Wow! This is just great news! Congrats! 🥳
Also, could you sync your fork please? Your forked repo is outdated (develop branch). Or you can merge this PR 1 with rebase option.
Hi,
Also, could you sync your fork please? Your forked repo is outdated (develop branch). Or you can merge this PR 1 with rebase option.
My forked repository is now up to date.
My forked repository is now up to date.
Not yet! 😜 Your master branch is still behind ThreeMammals's one. 😉 I know master is not default branch now, but you could sync everything by Sync fork button.
@Burgyn commented on Jul 13
It makes sense. I'll take a look at it and try to make a meaningful demo. It won't be right away though, I expect a couple of weeks before I get around to it.
What about demo and sample app? Do you have a time to contribute? It seems it will be another PR for another feature branch...
@raman-m commented on Aug 23
@Burgyn Hi Miňo! I've asked you about a demo 2 months ago... No feedbacks from you! Are you still with Ocelot? Can we plan to develop this feature or close this PR? I believe we could add a sample app to demonstrate the power of your library.
Hi @raman-m, Sorry for the delayed response. I've been quite busy lately.
I plan to create a demo and probably submit it as a new PR sometime in December. Thanks for your patience.
@Burgyn commented on Nov 1, 2023
Ah, it was in December '23, yet now it's June 2024. Do you plan to develop a sample project to showcase your library?
P.S. The feature branch has been rebased.