Ocelot icon indicating copy to clipboard operation
Ocelot copied to clipboard

Configurable default timeout for `HttpMessageInvoker`

Open danielcandea opened this issue 4 years ago • 5 comments

New Feature

Enable configurability of the default timeout for MessageInvokerPool. Functions of new properties:

  • A global timeout in the FileGlobalConfiguration section would set a default timeout value for all routes, applicable to both QoS and non-QoS scenarios.
  • A local, route-level timeout in FileRoute settings would take precedence, allowing for the overriding of the global default value.

Motivation for New Feature

Setting a custom default global timeout is simpler than configuring QoS settings for each handler, particularly when multiple handlers are defined.

Notes

There is an undocumented Timeout property which is not implemented: https://github.com/ThreeMammals/Ocelot/blob/cc8f5c5dfc7c56e4446a2e80d97391429c8b364d/src/Ocelot/Configuration/File/FileRoute.cs#L75

danielcandea avatar Aug 17 '20 09:08 danielcandea

@RaynaldM Useful? Could your team develop this feature please?

The issue has been shifted to the current monthly May-June'24 release to provide your team with ample time for development.

raman-m avatar May 09 '24 15:05 raman-m

@danielcandea Do you have intention to contribute?

raman-m avatar May 09 '24 15:05 raman-m

@raman-m I'm not in the team using Ocelot anymore, for a long time now. The file I mentioned doesn't exist anymore, I would need to get familiar with the code again, after almost four years. I can't commit time at the moment but would love to give this a go at some point in in the future. If this isn't ok for you, I'm happy to close this.

danielcandea avatar May 09 '24 15:05 danielcandea

@danielcandea Thanks for the feedback! This issue will not be closed. We will develop it within the current May-June'24 milestone.

raman-m avatar May 11 '24 08:05 raman-m

@raman-m commented on May 9:

@RaynaldM Useful?

It is

RaynaldM avatar May 13 '24 14:05 RaynaldM