#1305 RateLimiting headers

[jlukawska]

Fixes #1305

• #1305

Proposed Changes

• It doesn't work because the headers are set on the newly created HttpContext and not the original one that is returned with a response. The fix is that the rate limiting headers are set for the original HttpContext returned by HttpContextAccessor.

[jackletter]

finnaly HttpResponseFeature.OnStarting was invoked, but HttpResponseFeature.OnStarting method body has nothing

[garybond]

+1 to get this merged. This is stopping me being able to update a project to net6.0 + Ocelot v18

[jackletter]

收到了 哈哈

[Versa78]

+1 We need this fix as well

[raman-m]

The feature branch has been rebased onto ThreeMammals:develop!

We can start the code review...

[jackletter]

收到了 哈哈

[raman-m]

@jackletter commented on Oct 24, 2020:

finnaly HttpResponseFeature.OnStarting was invoked, but HttpResponseFeature.OnStarting method body has nothing

Is this a result of code review (testing)? If Not, could you review the code please?

---

P.S. Don't write non-English messages please!

[raman-m]

@garybond @Versa78 @neetra @nls44 Welcome to the code review! Your opinion is highly required.

[alex-pollan]

Hi guys, any update on this?

[raman-m]

@alex-pollan commented on Oct 20

Hi Alex! Need this bug fix to be included to release? It should not be hard to complete code review... I will try to prioritize and include the bugfix to October's release...