watermill
watermill copied to clipboard
feat(metrics): add opentelemetry support
Signed-off-by: ahkui [email protected]
#574
Motivation / Background
Implement metrics collection using the OpenTelemetry MeterProvider
Detail
Implement metrics collection using the OpenTelemetry MeterProvider
Alternative approaches considered (if applicable)
Checklist
The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:
- [ ] I wrote tests for the changes.
- [x] All tests are passing.
- If you are testing a Pub/Sub, you can start Docker with
make up. - You can start with
make test_shortfor a quick check. - If you want to run all tests, use
make test.
- If you are testing a Pub/Sub, you can start Docker with
- [x] Code has no breaking changes.
- [x] (If applicable) documentation on watermill.io is updated.
- Documentation is built in the github.com/ThreeDotsLabs/watermill/docs.
- You can find development instructions in the DEVELOP.md.
Hi @roblaszczak and @m110,
Could you please help review this PR when you have a moment?
Thanks!
We had this issue with OpenTelemtry in many projects: https://github.com/open-telemetry/opentelemetry-go/issues/4476
To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.
I would moving those changes to a separate components/opentelemetry package.
Do you feel you'll have time for that @ahkui? Let us know!
We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476
To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.
I would moving those changes to a separate
components/opentelemetrypackage.Do you feel you'll have time for that @ahkui? Let us know!
@roblaszczak yes, i can handle that
the new pkg i will move to components/metrics/opentelemetry, do you have other suggestion for the location ?
We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476 To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected. I would moving those changes to a separate
components/opentelemetrypackage. Do you feel you'll have time for that @ahkui? Let us know!@roblaszczak yes, i can handle that
the new pkg i will move to
components/metrics/opentelemetry, do you have other suggestion for the location ?
Hey, I discussed it with @m110 and since it looks orthogonal to the metrics package we can keep it flat (keeping it in sub-directory would suggest that it depends on metrics).
So I would suggest components/opentelemetry. It will be also easier to find :-)