watermill icon indicating copy to clipboard operation
watermill copied to clipboard

Add context propogation to subscribers for local pub-sub

Open yashb042 opened this issue 1 year ago • 4 comments

Solves Issue - https://github.com/ThreeDotsLabs/watermill/issues/464

Update 1 -

Have not added extra variables in Message struct, because the Message struct is used by every publisher-subscriber

Update 2 - Couldn't test the func - TestMessageCtx in test_pubsub.go It's mentioned that "ExactlyOnceDelivery test is not supported yet"

yashb042 avatar Sep 03 '24 05:09 yashb042

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (8d78dbe) to head (867fb77). Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
pubsub/tests/test_asserts.go 72.72% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   66.96%   67.15%   +0.18%     
==========================================
  Files          64       64              
  Lines        4289     4344      +55     
==========================================
+ Hits         2872     2917      +45     
- Misses       1242     1250       +8     
- Partials      175      177       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 04 '24 14:09 codecov[bot]

Thank you @yashb042! This looks solid to me, just a couple of minor comments.

m110 avatar Sep 04 '24 14:09 m110

Also, @m110

Update 2 - Couldn't test the func - TestMessageCtx in test_pubsub.go It's mentioned that "ExactlyOnceDelivery test is not supported yet"

How would we proceed testing this func - TestMessageCtx

yashb042 avatar Sep 05 '24 07:09 yashb042

Before reviewing, I will wait for you to reply to this message, because I feel like the code might change again https://github.com/ThreeDotsLabs/watermill/pull/487#discussion_r1749848993

ccoVeille avatar Sep 09 '24 18:09 ccoVeille

I find back this old PR.

Is there anything blocking or to be discussed that prevent it to be merged?

ccoVeille avatar Jul 13 '25 10:07 ccoVeille