watermill icon indicating copy to clipboard operation
watermill copied to clipboard

[watermill-googlecloud] Subscription configuration update support

Open condorcet opened this issue 2 years ago • 0 comments
trafficstars

Hello!

We can customize subscription settings when creating it.

But for existing subscription will be used current configuration from Google cloud. We cannot customize them if needed. https://github.com/ThreeDotsLabs/watermill-googlecloud/blob/8bfa935bf8e7c92b9836cafbc3a1587b452f3e2a/pkg/googlecloud/subscriber.go#L377

Google pub/sub has appropriate method https://pkg.go.dev/cloud.google.com/go/pubsub#Subscription.Update It operates with a different structure https://pkg.go.dev/cloud.google.com/go/pubsub#SubscriptionConfigToUpdate (all fields are optional unlike original SubscriptionConfig). However, I think it is possible to support this feature in adapter somehow.

condorcet avatar Mar 28 '23 10:03 condorcet