watermill icon indicating copy to clipboard operation
watermill copied to clipboard

Published 20 hours ago • verified publisher icon ThreeDotsLabs

[watermill-kafka] Allow other tracing instrumentations

Open doron-cohen opened this issue 2 years ago • 4 comments

Hi, watermil-kafka allows tracing with OTEL. Seems like it is very hard coded and baked in. I would love to be able to trace with another tracer (e.g. Datadog's ddtrace). I think it will be more fitting to the extensible nature of this project. Thanks.

doron-cohen avatar Jan 10 '23 13:01 doron-cohen

Hi, this https://www.datadoghq.com/blog/ingest-opentelemetry-traces-metrics-with-datadog-exporter/ do not work for you?

wiliamsouza avatar Jan 10 '23 16:01 wiliamsouza

This looks like a solution to when the entire app is traced using OTEL. We might go there someday but right now we trace using Datadog's lib. I didn't quite understand if there is a way to continue an OTEL trace with a Datadog's one. For example, if a message is incoming and it has an OTEL trace ID, how does the ddtrace will continue tracing? I know the span and trace IDs are structured differently.

doron-cohen avatar Jan 11 '23 07:01 doron-cohen

This could be a good approach: https://github.com/jackc/pgx/blob/master/tracer.go LMK if you think the same and I could implement something as a PR.

doron-cohen avatar Jan 21 '23 05:01 doron-cohen

I pushed a fix for this issue in ThreeDotsLabs/watermill-kafka#24. @wiliamsouza @m110 could you guys take a look?

doron-cohen avatar May 15 '23 14:05 doron-cohen