watermill icon indicating copy to clipboard operation
watermill copied to clipboard

Protobuf binding for message.Message?

Open AlexCuse opened this issue 2 years ago • 3 comments

I find myself thinking about adding a protobuf marshaler to watermill-jetstream and wondering if it would make sense to include the contract definitions and generated files in watermill itself.

AlexCuse avatar Mar 21 '22 11:03 AlexCuse

Hey @AlexCuse, can you elaborate a bit more on how do you understand "protobuf marshaler" in that context?

roblaszczak avatar Mar 22 '22 20:03 roblaszczak

Id like to try using protobuf for the actual transport encoding of watermill messages to see if it's "worth it" from a performance perspective. Likely have a better idea later this week if it's worth pursuing further but was thinking making the contract part of the message package could make sense.

AlexCuse avatar Mar 22 '22 21:03 AlexCuse

https://github.com/AlexCuse/watermill-jetstream/commit/b98a7cdb4a98516fac7f6d699c565b59d4c65b37

The stuff in the wmpb package there is what I was thinking of.

AlexCuse avatar Mar 23 '22 01:03 AlexCuse