watermill-kafka icon indicating copy to clipboard operation
watermill-kafka copied to clipboard

commit offset explicitly when AutoCommit is disabled and added Test Code for Manual Commit

Open tjnet opened this issue 1 year ago • 1 comments

context

I followed his suggestion

Can you add a test for that case in that file: https://github.com/ThreeDotsLabs/watermill-kafka/blob/master/pkg/kafka/pubsub_test.go

I think that it is not needed to run entire tests.TestPubSub. I think that it should be enough to use TestPublishSubscribe from the test suite.

could you confirm when you have time?

tjnet avatar May 16 '23 15:05 tjnet

@roblaszczak Hi. We disabled autocommit and experienced error which is fixed in this PR. Is it real to merge it? It's very necessary for us. Thanks.

voodoo-dn avatar Jun 06 '24 18:06 voodoo-dn