blikvm
blikvm copied to clipboard
ThomasVon2021
Include copyright notice for third-party code
./package/kvmd-hid/enable-gadget.sh seems to be derived from TinyPilot's copyrighted code here:
https://github.com/tiny-pilot/ansible-role-tinypilot/blob/master/files/init-usb-gadget
./package/kvmd-hid/disable_gadget.sh seems to be derived from TinyPilot's copyrighted code here:
https://github.com/tiny-pilot/ansible-role-tinypilot/blob/master/files/remove-usb-gadget
TinyPilot's code is released under the MIT license, so you're welcome to include it, but the license requires preserving the copyright notice and license.
You can get back into compliance with the license this by copying the text from TinyPilot's license as a header at the top of each derived file or by including TinyPilot's license in a file called NOTICE at the root of the repo.
https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/disable_gadget.sh https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/enable-gadget.sh Thank you for reminding me. It's correct.
@ThomasVon2021 - The license notice was removed in https://github.com/ThomasVon2021/blikvm/commit/74b7bd0d8df57922b05f207716411421b16dcc67#diff-13cf57767c8d201ac67a5de3c2f07904a3b64bb3e48075446c10c31f14f68c77
You're required to either remove the file or preserve the license.
https://github.com/ThomasVon2021/blikvm/commit/0deef067b4d728074f35037841a0f2b41acabb66 Thank you for your remind.
I have a question to ask you. I use GPL-3.0 license for other code, should I also add this description to all my original code?
It varies by project. Some choose to include the notice on every file, and others choose a single license file at the root. See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#determining-the-location-of-your-license
@ThomasVon2021 - I see you've again marked this as completed without actually complying with the license. Please link to where the license has been honored. Otherwise, you are still in violation of TinyPilot's MIT License.
https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/enable-gadget.sh https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/disable-gadget.sh
Still retained and not removed, please help point out the specific issues.
Sorry, you're correct. I didn't realize that the link in the original comment was to an old commit rather than the latest in master.