CuraEngine icon indicating copy to clipboard operation
CuraEngine copied to clipboard

Merge?

Open Hello1024 opened this issue 3 years ago • 3 comments

Did you attempt to get this merged into Cura? Is there a PR?

Hello1024 avatar Jul 28 '22 17:07 Hello1024

There is a draft PR. I hope to get a bit more feedback (and i also need to update when I have time) before removing draft status. When/if I ask them to look at the over 4000 lines of code I want it to be as good as possible.

ThomasRahm avatar Jul 30 '22 17:07 ThomasRahm

I'm still using this as my daily and tbh I think it's a shame it's getting slept on by not just Cura but the likes of prusaslicer/superslicer/etc. It's so much better than the stock Cura tree supports - which I'm pretty sure Bambu imported into their prusaslicer fork.

chrisvanderpennen avatar Aug 15 '22 01:08 chrisvanderpennen

I actually checked the source, Bambu did indeed port the original Cura Tree Support. There is definitely some attention around this Implementation (@ThomasRahm plz consider getting your PR out of the draft state); I'm pretty sure Prusa is aware, too.

DerGenaue avatar Aug 18 '22 22:08 DerGenaue

tbh I think it's a shame it's getting slept on by not just Cura but the likes of prusaslicer/superslicer/etc.

@chrisvanderpennen There you go; now it is public that the new "organic support" that'll be released with the next Prusa Slicer version (2.6) is based on this Tree Support Fork! Cura also seems to have accelerated their efforts to merge this Fork, so exciting times ahead!

DerGenaue avatar Dec 13 '22 18:12 DerGenaue