intellij-diff-plugin icon indicating copy to clipboard operation
intellij-diff-plugin copied to clipboard

Published 20 hours ago • verified publisher icon ThomasR

False positive syntax errors

Open qvint opened this issue 5 years ago • 2 comments

If you open this patch, second file name will be highlighted as if there is a syntax error:

DiffTokenType.EOL_HINT, DiffTokenType.OTHER, DiffTokenType.UNIFIED_COMMON_LINE, DiffTokenType.UNIFIED_DELETED_LINE, DiffTokenType.UNIFIED_INSERTED_LINE, DiffTokenType.UNIFIED_LINE_NUMBERS or DiffTokenType.WHITE_SPACE expected, got '--- a/base/time/time...'

Plugin version: v2.1.1 IntelliJ IDEA 2019.1 Beta (Ultimate Edition)

diffp

qvint avatar Mar 16 '19 16:03 qvint

Thanks for the report, I'll look into it.

ThomasR avatar May 31 '19 06:05 ThomasR

It's trickier than I thought. Unfortunately the diff format is a beast, not well-suited for the JFlex lexer generator, which this plugin is using.

If anyone wants to help, PRs are welcome.

ThomasR avatar Sep 24 '19 19:09 ThomasR