ThomasPiellard issues

Results 17 issues of


                                            ThomasPiellard

plonk audit record

This is a tracking record of the findings in the audit. Critical bugs have been corrected for linea. The numbers correspond to the findings in the audit - [x] 4-1...

consolidate

zk-evm

bindPublicData should deal only with data in the verification key

Currently in plonk `bindPublicData` binds the challenge to the public data... and PI2, which belongs to the proof. Instead of ``` if err := bindPublicData(&fs, "gamma", *vk, publicWitness, proof.PI2); err...

cleanup

zk-evm

Feat/fflonk

# Description Implementation of [shplonk](https://eprint.iacr.org/2020/081.pdf) Implementation of [fflonk](https://eprint.iacr.org/2021/1167.pdf) (only the commitment) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which...

Feat/option solidity

# Description An option is added in `ExportSolidity` to add some solidity specific parameters, like the solc version. The signature is now `func (vk *VerifyingKey) ExportSolidity(w io.Writer, exportOpts ...solidity.ExportOption) error...

bug: fft

## Description This sample causes a panic: ``` a := make([]fr.Element, 4) f := fft.NewDomain(4, fft.WithoutPrecompute()) f.FFTInverse(a, fft.DIF) ``` ## Possible Fix `twiddlesInv = make([][]fr.Element, nbStages-twiddlesStartStage)` -> nbStages=2, twiddlesStartStage=3 here,...

Feat/poseidon2

# Description Implementation of poseidon2 for t=2,3 following [reference implementation](https://github.com/HorizenLabs/poseidon2/blob/main/plain_implementations/src/poseidon2/poseidon2_instance_bls12.rs) [reference paper](https://eprint.iacr.org/2023/323.pdf) TBD: algos 1, 2, 3 of https://tosc.iacr.org/index.php/ToSC/article/view/8913/8489 for finding internal matrices when t>3 ## Type of change Please...