prosody-filer icon indicating copy to clipboard operation
prosody-filer copied to clipboard

SomeThing wrong with HMAC

Open shizzgar opened this issue 2 years ago • 2 comments

Yo, ThomasLeister, Thanks for your work! Works like a charm, But i have some troubles with HMAC verify on Prosody 0.12, with all my clients (Conversation, Dino) Filer returns error code with message from here:

https://github.com/ThomasLeister/prosody-filer/blob/90f71d5e2d04b83ff99e129aecba1268a679c369/prosody-filer.go#L99-L105

So, i just rewrited a little to bypass this behavior Commented the above, and rewrite this line

https://github.com/ThomasLeister/prosody-filer/blob/90f71d5e2d04b83ff99e129aecba1268a679c369/prosody-filer.go#L119

To this:

if a != nil || a == nil {

It works, but i'm a bit confused, Because I want to do all the things right))

So, maybe @ThomasLeister could give me some advice?)

shizzgar avatar May 04 '22 14:05 shizzgar

I am having the same issue actually, I suspect it is because that parameter is not being passed in the request (I am using caddy and I am having trouble following nginx and apache examples). I however need some guidance as to where to go from here.

Rabioli avatar Dec 09 '22 06:12 Rabioli

Actually I digged into this and fixed it, it probably doesn't work because prosody 12 uses their v2 of the http upload external protocol by default so prosody-filer can't parse the url correctly, I forked the repo and fixed it. May make a pull request.

Rabioli avatar Jan 05 '23 19:01 Rabioli

PR merged - this will be merged into a new minor version of prosody-filer, soon. :)

ThomasLeister avatar Feb 17 '24 18:02 ThomasLeister