openssl-tpm-engine
openssl-tpm-engine copied to clipboard
ThomasHabets
update to 0.4.2; add rpm spec file
I've merged the code from http://sourceforge.net/projects/trousers/files/OpenSSL%20TPM%20Engine/ and added a spec file, which you may find useful.
You pulled 0.4.2 from upstream in this pull request? It includes generated files (e.g. "configure") which should not be in version control, and doesn't include the incremental changes I assume upstream has somewhere in their version control.
Thomas Habets [email protected] wrote:
You pulled 0.4.2 from upstream in this pull request? It includes generated files (e.g. "configure") which should not be in version control, and doesn't include the incremental changes I assume upstream has somewhere in their version control.
Hmm. That appears to be what is in the tarball from http://sourceforge.net/projects/trousers/files/OpenSSL%20TPM%20Engine/0.4.2/openssl_tpm_engine-0.4.2.tar.gz/download.
Yes, released tarballs tend to have them, to not require the end user to have autotools installed. Generating them is then done as part of creating the tarball.
And some people do check in the generated files into source control.
In any case changes should be pulled in from source control, not tarballs.
Thomas Habets [email protected] wrote:
In any case changes should be pulled in from source control, not tarballs.
That makes sense to me.
I guess there was just some confusion about this GitHub repository versus the Sourceforge files.
Having found the sourceforge git files at http://sourceforge.net/p/trousers/openssl_tpm_engine/ci/master/tree/ feel free to ignore/cancel/discard this pull request.
Thanks!