angularjs-logDecorator icon indicating copy to clipboard operation
angularjs-logDecorator copied to clipboard

Demo #5 - Section Code missing dependency...

Open Zabeard opened this issue 11 years ago • 0 comments

Looks like copy and paste strikes again. The line in the Demo #5 section code on the README.md has a mistake, the actual code is correct in the repository however it's missing a dependancy on the code quoted.

    var dependencies = [
            'myApp/services/Authenticator',
            'myApp/controllers/LoginController'
        ],

should be

    var dependencies = [
            'mindspace/logger/ExternalLogger',
            'myApp/services/Authenticator',
            'myApp/controllers/LoginController'
        ],

Also is since this code is used in Quizzer but as part of the project it would be good to see how this project would change if it was used as an external dependency.

The reason is that "bundles" is not understood when you come to use the optimizer as part of the Guntfile.js -> prod build task. So how would a requirejs.compile change?

Zabeard avatar Jul 27 '14 19:07 Zabeard