BotTracker icon indicating copy to clipboard operation
BotTracker copied to clipboard

avoid sentence fragments in translations

Open Findus23 opened this issue 4 years ago • 0 comments

Hi,

Just a quick comment I saw on weblate (and also noticed myself):

Sentence fragments like "was deleted" are pretty hard to translate in many languages as the correct form depends on what was deleted.

But it seems like in this case there is an easier solution anyway:

https://github.com/Thomas--F/BotTracker/blob/b957d95511fb97202c45a84c8d8293dbaacaeb7e/Controller.php#L188

You could instead write something like

$errorList[] = Piwik::translate('BotTracker_Message_deleted', [$botId]);

with a key of Bot %s was deleted.

Findus23 avatar Sep 01 '21 16:09 Findus23