postgres-migrations icon indicating copy to clipboard operation
postgres-migrations copied to clipboard

rename cause to reason to avoid esnext conflicts

Open saintedlama opened this issue 2 years ago • 3 comments

saintedlama avatar May 13 '22 06:05 saintedlama

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

ThomWright avatar May 13 '22 08:05 ThomWright

Will do a second PR and see what's happening using an Error as cause

saintedlama avatar May 17 '22 14:05 saintedlama

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

Works with using type Error for cause. New PR https://github.com/ThomWright/postgres-migrations/pull/88

saintedlama avatar May 20 '22 16:05 saintedlama