doesn't work when bundled

[OmgImAlexis]

Because of this line the sql file ends up checking the relative location in this case it's dist instead of node_modules. Maybe inline this so it can be bundled? Or allow using the one supplied by the user.

https://github.com/ThomWright/postgres-migrations/blob/bc2b0cbe91824fc18a473cba9b80179536cefeef/src/files-loader.ts#L35

[ThomWright]

Hi, thanks for the issue.

By "bundled", do you mean you are merging the files in this library together into e.g. a single file?

Can I ask why?

[OmgImAlexis]

Yep, when using something like rollup I can deploy my app in a single file.

With this issue I'm currently needing to install this dep at runtime so I can use the version in node_modules.

[ThomWright]

Thanks.

I think I still don't understand why this is desirable! Is it to make distribution easier? Just give someone a single .js file and tell them to run it with Node?

Does e.g. rollup have docs on how to handle __dirname? I expect this could be a common problem.

[OmgImAlexis]

It's usually done for embedded apps and/or serverless like aws lambda. I'm honestly surprised this hasn't come up in the past.

Usually with rollup the __dirname will be rewritten to the base directory, thing is that's not going to help in this case as the file isn't in the base directory it's in node_modules.

I have a feeling the new way of getting __dirname might work in this case.

const __dirname = path.dirname(new URL(import.meta.url).pathname);

[mishabruml]

hey, any movement on this? I am getting the same error when bundling with esbuild

client = await pool.connect();
const migrationsDir = path.resolve('resources/migrations');
console.log(migrationsDir);
await migrate({ client }, migrationsDir);

/usr/app/resources/migrations # result of console.log(migrationsDir). Directory exists on docker image at expected location

error:   ┏ Error running db migrations ENOENT: no such file or directory, open '/usr/app/migrations/0_create-migrations-table.sql' - Offending file: '0_create-migrations-table.sql'.

error:   ┃ [ 1] Error: ENOENT: no such file or directory, open '/usr/app/migrations/0_create-migrations-table.sql' - Offending file: '0_create-migrations-table.sql'.

The path that the library tries to resolve is incorrect, its missing the /resources/ /usr/app/migrations/0_create-migrations-table.sql is an invalid path /usr/app/resources/migrations/0_create-migrations-table.sql is a valid path

When running locally via ts-node there is no issues

[ThomWright]

How have other libraries solved this? I expect other libraries read files in similar ways and have had the same problem.

I'm open to solutions, but I don't have much time at the moment to think about, research and test this.

[mishabruml]

How have other libraries solved this? I expect other libraries read files in similar ways and have had the same problem.

I'm open to solutions, but I don't have much time at the moment to think about, research and test this.

Have a look through https://github.com/evanw/esbuild/issues/859

[mishabruml]

You could try e.g. path.join(process.cwd()) from https://github.com/evanw/esbuild/issues/859#issuecomment-790868963

[ThomWright]

You could try e.g. path.join(process.cwd()) from https://github.com/evanw/esbuild/issues/859#issuecomment-790868963

I would be surprised if that worked in a normal Node.js/NPM environment.

Perhaps you would like to try it?

I see you're also based in Bristol, hi!

[mishabruml]

You could try e.g. path.join(process.cwd()) from evanw/esbuild#859 (comment)

I would be surprised if that worked in a normal Node.js/NPM environment.

Perhaps you would like to try it?

I will try and get some time

I see you're also based in Bristol, hi!

I was gonna say the same thing 😀 Wasson me babber!

[khromov]

:wave: Also running into this issue. As for why we want to bundle postgres-migrations:

We're developing a SvelteKit application. SvelteKit is a meta framework that automates building isomorphic applications, compiled to both frontend and backend bundles using Vite. I'm then packaging the resulting bundles into a Docker image. If I can't bundle postgres-migrations I'd have to include my entire node_modules folder into the Docker image which makes it about 4x larger than if I just include the bundled version.

Because postgres-migrations will always run on the server bundle, I can actually fetch the path there using:

import path from 'path';
import { fileURLToPath } from 'url';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

However since postgres-migrations just reads the global __dirname when I try to run pgMigrations.migrate(...) I get:

ReferenceError: __dirname is not defined`.

This happens at this line of code that includes the "0" migration. If only this line could be handled in a different way (for example, by inlining the initial zero migration) then this whole package should work fine even when bundling!

[khromov]

I made a PR with a workaround for this issue. In short it involves copying the initial migration to your local migrations folder to skip the use of __dirname.

You can read more here: https://github.com/ThomWright/postgres-migrations/pull/99

This will hopefully get merged but if you want to use my fork temporarily you can change your package.json file to look like this and then run npm i:

"postgres-migrations": "https://github.com/khromov/postgres-migrations",

PS. Keep in mind the fork doesn't have the dist/ files so you need TypeScript support in your bundler and you will need to import the module like this:

import { migrate } from 'postgres-migrations/src/index';