BasicLinearAlgebraToolsPurePy icon indicating copy to clipboard operation
BasicLinearAlgebraToolsPurePy copied to clipboard

Error with the `determinant_fast` function

Open piratax007 opened this issue 3 years ago • 1 comments

Hi, I'm implementing the determinant_fast function and test this with the following matrix [[1, 2, 3, 4, 5], [4, 5, 6, 4, 3], [0, 0, 0, 1, 5], [1, 3, 9, 8, 7], [5, 8, 4, 3, 11]].

This method is not a good idea if any pivot is zero.

piratax007 avatar Jan 28 '21 12:01 piratax007

I came across this issue when trying to implement the algorithm as well so I posted a fix in a pull request that deals with that here: https://github.com/ThomIves/BasicLinearAlgebraToolsPurePy/pull/3

RandomGamingDev avatar Nov 24 '23 05:11 RandomGamingDev