miflora-mqtt-daemon icon indicating copy to clipboard operation
miflora-mqtt-daemon copied to clipboard

Published 20 hours ago • verified publisher icon ThomDietrich

Add firmware version to MQTT messages

Open chrostek opened this issue 6 years ago • 6 comments

It would be nice to have the firmware version in the json of the mqtt message.

chrostek avatar Apr 08 '18 15:04 chrostek

Hey, this request depends on the convention you are referring to. In the default one, the firmware is part of the announcement message, isn't it?

ThomDietrich avatar Apr 10 '18 09:04 ThomDietrich

Hey, thanks! There was no documentation for the announcement. found it in the code. works.

chrostek avatar Apr 11 '18 18:04 chrostek

That is something concerning. Would you like to add something to the README?

ThomDietrich avatar Apr 12 '18 08:04 ThomDietrich

Maybe in "Integration" ... some info about the topic and content of the accouncement. or is this some standard? i dont know much about mqtt :-)

chrostek avatar Apr 12 '18 17:04 chrostek

Good question! The default mode is not standardized. However not having a standard is tricky. That is why we are working on a convention and it is also supported by the daemon: https://github.com/ThomDietrich/miflora-mqtt-daemon/blob/master/config.ini.dist#L11

Yes definitely in Integration. It would be great if you could submit a PR. Just add another paragraph and mention the additional messages. Thanks!

ThomDietrich avatar Apr 18 '18 13:04 ThomDietrich

My english is not very good. i dont like to add things to the readme ... sorry

chrostek avatar Apr 23 '18 06:04 chrostek