Thomas Smith

Results 165 comments of Thomas Smith

I agree that it's weird that `FOO` and `FOO.toUppercase()` have different highlighting. I suspect that this is inadvertent — that the rule is intended for e.g. `Foo.toUpperCase()`, but `FOO` matches...

See #2267. Currently, function assignment detection is done with a dumb lookahead. This is fundamentally not a reliable method. One of these days, I need to rip out the whole...

See #2267. The lookahead could probably be improved to handle simple cases like the above, but it's probably about time I just rewrote function assignment detection altogether.

I haven't written any C in years, so I could be wrong. But isn't the example code invalid? ```c void print_single_register(char *register, pid_t child_pid); ``` Will this compile, or will...

I think that if we were to introduce special highlighting for invalid parameter names (which I don't have a position on, not being familiar with the C syntax definition), we...

See also #1563. Generally, the core syntax only provides support scopes for things that are part of the language itself, rather than specific to the browser or to Node. There...

> the reality is that the browser, Node and Electron probably cover 99.9999% of JS environments in practice Sure, but this is three different environments. Back in the days before...

I'd also recommend taking a look at the Lua syntax definition, which has a similar structure to the JavaScript definition but is much simpler. The Lisp definition should be easy...

That one improves arrow function detection, but it still uses awkward lookaheads to highlight the “names” of anonymous functions. I've been looking into ways to rewrite that to avoid the...

It sounds like we're talking about the following four types of constructs: 1. Definitions of namespaces (e.g. `namespace foo {}` in C++). Here, the whole construct should get a meta...