Sublime-JS-Custom icon indicating copy to clipboard operation
Sublime-JS-Custom copied to clipboard

Don't highlight environment-specific builtins

Open szw opened this issue 6 years ago • 5 comments

Hi!

I ❤️ your plugin! :). Especially because it's fast and does the job without trying to turn Sublime Text into a bloated IDE :). Thanks for a great work!

I found some inconsistency in highlighting .size in object literals. Here's a code to reproduce:

function foo (x) {
  return {
    s: x.size,
    l: x.length
  }
}

I use Mariana color scheme with Adaptive theme on mac OS.

Thanks!

szw

szw avatar May 02 '18 06:05 szw

Same goes with .domain, .name etc. I guess it is triggered by this line: https://github.com/Thom1729/Sublime-JS-Custom/blob/0f07ccb1108bbf535f0e0006bba0a7ce5524a2e0/src/JavaScript.yaml#L1838

szw avatar May 04 '18 12:05 szw

This behavior is part of the core syntax. Down the road, I would like to provide the option to disable this.

Thom1729 avatar May 09 '18 16:05 Thom1729

That would be great! In node development I found that highlighting pretty annoying.

szw avatar May 20 '18 09:05 szw

Related: https://github.com/sublimehq/Packages/issues/1563.

Thom1729 avatar May 21 '18 02:05 Thom1729

See https://github.com/sublimehq/Packages/pull/1641, which will clear the way for this.

Thom1729 avatar Jul 11 '18 01:07 Thom1729