Emelia Smith
Emelia Smith
@davidlehn @dgarijo one thing that could be done on this repo is adding a CODEOWNERS file, and then all the teams responsible for their areas would be tagged in PRs...
For what it's worth, this is also reproducible in `pg-connection-string`: ```js const parse = require('pg-connection-string').parse; parse("postgres://someuser:foo?#bar@localhost:12345/dbname") ``` Output: ``` Uncaught TypeError: Invalid URL at new URL (node:internal/url:775:36) at Function.parse (/Users/emelia/Work/IFTAS/repos/fedicheck/app/node_modules/pg-connection-string/index.js:29:14)...
@Dcallies if you can clarify on here which tests these are and how you'd manually run them, I'd be happy to do up a pull request for a GitHub Actions...
Can confirm this doesn't appear to work
Interesting! It looks like authentik is just using compiled python for these, so you might be able to do: ```python from urllib.parse import parse_qs query_params = request.http_request.GET.get("query") parsed = parse_qs(query_params)...
Why's the session needed for the creation of the token? The token creation only relies on the authorization code? You might want to use the `before_successful_authorization` configuration hook instead.
Could this actually be due to a change in libicu? The other issue was, iirc, a change in ruby interfaces
> Is the updated charlock_holmes actually installable, and mastodon calls for the correct version now? Should be
Do keep in mind that Mastodon does **not** implement OIDC for API access, but does for SSO; That is, Mastodon is always an OAuth 2 provider / authorization server, however...
So what you'd want for Mastodon SSO to support PKCE is the PKCE configuration options passed to `config.omniauth :openid_connect, oidc_options` in https://github.com/mastodon/mastodon/blob/e56fb9e4890435ef89b56ef5d1b9a8d0d46ab938/config/initializers/3_omniauth.rb β currently it does not include those options:...