WidescreenFixesPack icon indicating copy to clipboard operation
WidescreenFixesPack copied to clipboard

[NFSU2] Windows 11 24H2 Update breaks widescreen fix

Open VirgilChen97 opened this issue 1 year ago • 34 comments
trafficstars

The NFSU2 widescreen fix works fine in Windows 23H2, but after updating to 24H2, the game launches with a prolonged black screen. Once in the main menu, all sounds, including background music, lag and repeat. However, removing dinput8.dll from the game folder allows it to run normally. Rolling back to 23H2 resolves the issue, enabling the widescreen fix to function properly.

VirgilChen97 avatar Oct 23 '24 07:10 VirgilChen97

Kind of a duplicate of #1573

bscout9956 avatar Nov 07 '24 00:11 bscout9956

Kind of a duplicate of #1573

Wish I could help, but I can't reproduce any of this.

ThirteenAG avatar Nov 07 '24 04:11 ThirteenAG

NFSUnderground2.WidescreenFix.zip

Does this build changes anything?

ThirteenAG avatar Nov 07 '24 04:11 ThirteenAG

@ThirteenAG That resolved it for me, thanks!

martinmine avatar Nov 07 '24 22:11 martinmine

@ThirteenAG Yeah that fixed it for me too. Good work!!

bscout9956 avatar Nov 09 '24 04:11 bscout9956

Good to know, but please compare with this build as well, does it still work?

NFSUnderground2.WidescreenFix.zip

ThirteenAG avatar Nov 09 '24 04:11 ThirteenAG

Good to know, but please compare with this build as well, does it still work?

NFSUnderground2.WidescreenFix.zip

Yes, still works!

bscout9956 avatar Nov 09 '24 06:11 bscout9956

Thanks, will update a bit later.

ThirteenAG avatar Nov 09 '24 06:11 ThirteenAG

@bscout9956 The previous builds are incorrect, this one should be, please also check this one.

NFSUnderground2.WidescreenFix.zip

ThirteenAG avatar Nov 10 '24 03:11 ThirteenAG

Doesn't work. Black screen.

bscout9956 avatar Nov 10 '24 04:11 bscout9956

Well, in that case I'll just go with Silent's implementation instead. Lmk if that works.

NFSUnderground2.WidescreenFix.zip

ThirteenAG avatar Nov 10 '24 04:11 ThirteenAG

Well, in that case I'll just go with Silent's implementation instead. Lmk if that works.

NFSUnderground2.WidescreenFix.zip

Nope, in fact I had quite a struggle to force close the game this time around.

bscout9956 avatar Nov 10 '24 04:11 bscout9956

To be clear, this one works:

File: NFSUnderground2.WidescreenFix.asi SHA-1: b58ac3b8b0c74af84312dcadb54d51d86b569635 SHA-256: 42f7661b47ff19f286fa73e47c989285f6fac3b0282e9deca742cbdd4c2da431

bscout9956 avatar Nov 10 '24 04:11 bscout9956

It's this line of code that's causing it:

https://github.com/ThirteenAG/WidescreenFixesPack/blob/8932d30f211ff738c0d860213d4e61f8123a43f8/source/NFSUnderground2.WidescreenFix/dllmain.cpp#L905

Now the question is, is it even needed? I would say it can be safely deleted, but maybe I can ping @CookiePLMonster and see what he has to say.

ThirteenAG avatar Nov 10 '24 05:11 ThirteenAG

Meanwhile, @bscout9956, any chance you could test Scarface with https://github.com/CookiePLMonster/SilentPatchScarface and see if it has the same issue?

ThirteenAG avatar Nov 10 '24 05:11 ThirteenAG

It's this line of code that's causing it:

https://github.com/ThirteenAG/WidescreenFixesPack/blob/8932d30f211ff738c0d860213d4e61f8123a43f8/source/NFSUnderground2.WidescreenFix/dllmain.cpp#L905

Now the question is, is it even needed? I would say it can be safely deleted, but maybe I can ping @CookiePLMonster and see what he has to say.

Without this call you're not constraining affinity of the game thread so yes, it's likely needed.

CookiePLMonster avatar Nov 10 '24 08:11 CookiePLMonster

It's this line of code that's causing it: https://github.com/ThirteenAG/WidescreenFixesPack/blob/8932d30f211ff738c0d860213d4e61f8123a43f8/source/NFSUnderground2.WidescreenFix/dllmain.cpp#L905

Now the question is, is it even needed? I would say it can be safely deleted, but maybe I can ping @CookiePLMonster and see what he has to say.

Without this call you're not constraining affinity of the game thread so yes, it's likely needed.

Any other ideas then what might be breaking here? After all, it used to work fine, and still works for me, even on 24h2.

ThirteenAG avatar Nov 10 '24 08:11 ThirteenAG

No idea - has the DLL patching been delegated to another thread maybe? Or some third party code injected into the thread?

CookiePLMonster avatar Nov 10 '24 09:11 CookiePLMonster

No clue, asi wasn't updated in a long time, so it's unlikely dependencies or my code changes broke it.

@bscout9956

NFSUnderground2.WidescreenFix.zip

Check this one too, I doubt it fixed the issue, but who knows.

ThirteenAG avatar Nov 10 '24 14:11 ThirteenAG

No clue, asi wasn't updated in a long time, so it's unlikely dependencies or my code changes broke it.

@bscout9956

NFSUnderground2.WidescreenFix.zip

Check this one too, I doubt it fixed the issue, but who knows.

Nope. image

Your code is fine I believe. Unsure about dependencies. It's really Windows (mis)behaving weirdly, as I tested the game under Arch Linux (Wine) with the same files, mods and everything and it works just fine.

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Hold on... I just tried launching it again to see if this option was causing issues: image

Then I checked taskmgr image Suspended? That makes no sense.

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Do you have this setting in windows defender enabled by any chance?

image

ThirteenAG avatar Nov 10 '24 15:11 ThirteenAG

Hold on... I just tried launching it again to see if this option was causing issues: image

Then I checked taskmgr image Suspended? That makes no sense.

And what if you resume manually, will it continue working then?

ThirteenAG avatar Nov 10 '24 15:11 ThirteenAG

Do you have this setting in windows defender enabled by any chance?

image

Nope. image

Also, worth noting this reply to my original issue: image I'm also playing at 1440p (in my case I have set 125% scaling). Though I just tried 1080p and got nothing lol.

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Can you test 1080p?

ThirteenAG avatar Nov 10 '24 15:11 ThirteenAG

Nope, but I just tested 60hz. image And it worked. It doesn't seem to like my monitor's 180hz, nor 120hz mode. It does fine with 75hz!

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Oh god. I tried to take a screenshot but the indicator changed to 180hz. But it also worked at 100hz.

image

Now I don't know if it's running at 180hz in game or 100hz. :l

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Ok. It seems the game runs fine if the receiving signal is a proper 60hz signal or so. image Sometimes when I set it to 60hz the signal is still a 120hz signal. 59.95 doesn't seem to suffer from this issue. image

bscout9956 avatar Nov 10 '24 15:11 bscout9956

Can you reinstall the currently released version, then launch the game, and when the issue appears, just make a dump of the process via the task manager. Upload somewhere like easyupload and post the link here.

ThirteenAG avatar Nov 10 '24 15:11 ThirteenAG

Can you reinstall the currently released version, then launch the game, and when the issue appears, just make a dump of the process via the task manager. Upload somewhere like easyupload and post the link here.

Done! https://easyupload.io/60ns5w

bscout9956 avatar Nov 10 '24 15:11 bscout9956