aioinject icon indicating copy to clipboard operation
aioinject copied to clipboard

Support for subscriptions in strawberry.

Open nrbnlulu opened this issue 1 year ago • 2 comments

Warning: do not merge

This pr adds test for when extensions on subscriptions are supported in strawberry upstream.

nrbnlulu avatar Jul 07 '24 15:07 nrbnlulu

Looks good so far, by the way generally with things such as websockets and subscriptions (anything longer lived than a single request) it would be better to use DI system directly to avoid hanging onto resources such as db connections.

notypecheck avatar Jul 07 '24 15:07 notypecheck

Looks good so far, by the way generally with things such as websockets and subscriptions (anything longer lived than a single request) it would be better to use DI system directly to avoid hanging onto resources such as db connections.

Can be kinda anoying if your subscription returns a Node for example. Because it can be resolved to so many types. therefor you'd be finding yourself using the DI system manually all over the place.

nrbnlulu avatar Jul 07 '24 16:07 nrbnlulu