YT-Spammer-Purge icon indicating copy to clipboard operation
YT-Spammer-Purge copied to clipboard

Grammar Mistakes And Added Colors In Some Places

Open Rohith0009 opened this issue 2 years ago • 13 comments

Related Issue/Addition to code

  • Addition to code.

Type of change

Features And a Very Minor Fix

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)

Proposed Changes

  • Fixes Spelling and Grammer Mistakes
  • Added New Colors In headings and inputs
  • Fixed Where 2 Print Statements were in the same line

Why is this change needed?

It's required because YT Spammer Purge Needs good grammar and spelling. The Second Change Is Needed So That The Terminal Looks Good And Colorful. The Fixes are So that the code runs properly.

Additional Info

  • Changed Colors in Headings And Inputs
  • In Scripts/auth.py line number 154. Both Prints were on the same line

Checklist:

  • [x] My code follows the style guidelines of this project and I have read CONTRIBUTING.md
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Screenshots

Original

Before

Updated

After

Rohith0009 avatar Sep 25 '22 02:09 Rohith0009

Also I Removed The "Big Bruh Moment" As I don't think those types of words belong here. If you don't like this change I can revert it.

Rohith0009 avatar Sep 25 '22 02:09 Rohith0009

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

Rohith0009 avatar Sep 25 '22 08:09 Rohith0009

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

Yea there shouldn't be an apostrophe there

ThioJoe avatar Sep 25 '22 23:09 ThioJoe

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

Yea there shouldn't be an apostrophe there

Ok I have changed it. Is Everything else Ok?

Rohith0009 avatar Sep 26 '22 06:09 Rohith0009

@ThioJoe I added a new bug fix is it ok?

Rohith0009 avatar Sep 26 '22 12:09 Rohith0009

@ThioJoe I added a new bug fix is it ok?

What's the bug exactly? Your code actually breaks some things, for example if there's an invalid input it just keeps the program going anyway. Probably better to revert 5a2bf9c

ThioJoe avatar Sep 27 '22 15:09 ThioJoe

What's the bug exactly? Your code actually breaks some things, for example if there's an invalid input it just keeps the program going anyway. Probably better to revert 5a2bf9c

Done. Sorry for breaking the code

Rohith0009 avatar Sep 27 '22 15:09 Rohith0009

README.md line 88, fairly irrelevant but I don’t believe Simply and Click should be compounded.

I don't think for makes a good sentence over there.

Rohith0009 avatar Sep 29 '22 15:09 Rohith0009

I hope not

spankywetfish avatar Nov 09 '22 09:11 spankywetfish

Is that one error going to stay that way?

Going to fix it

Rohith0009 avatar Nov 10 '22 14:11 Rohith0009

hey, can you assign this to me? I would like to contribute to this repo.

LoftyDroid avatar Dec 02 '22 19:12 LoftyDroid

hey, can you assign this to me? I would like to contribute to this repo.

I don't think that the pull request can be assigned to you Lofty, FYI.

LunaticBFF57 avatar Dec 04 '22 08:12 LunaticBFF57

Sure.

dwarfpuzzles avatar May 09 '23 16:05 dwarfpuzzles

hey is this still being worked on

virophagesp avatar Apr 01 '24 23:04 virophagesp

Yo @Rohith0009?

LunaticBFF57 avatar Apr 03 '24 10:04 LunaticBFF57

Wait, are you not working on this or for some other reason?

LunaticBFF57 avatar Apr 03 '24 20:04 LunaticBFF57