manypkg icon indicating copy to clipboard operation
manypkg copied to clipboard

[dependencies-replacement] Replace fast-glob with tinyglobby

Open VanTanev opened this issue 1 year ago • 4 comments

References #221

Removes 15 dependencies from the graph.

VanTanev avatar Oct 15 '24 21:10 VanTanev

🦋 Changeset detected

Latest commit: b42593ea871fe59eeaa58fdac795acd6a4174336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@manypkg/tools Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 15 '24 21:10 changeset-bot[bot]

The chagned code doesn't have any tests attached to it. I am worried about changed behavior, possibly on Windows. Not sure how best to test it - maybe add a Windows CI path? Or, is Windows generally considered not supported?

VanTanev avatar Oct 15 '24 21:10 VanTanev

A CI job for windows would be appreciated regardless - it might be good to PR it separately from this.

I'm similarly worried about the changed behavior but as long as this is a widely used package and since we'll be releasing a new 0.x minor with those changes... it should probably be fine.

Andarist avatar Oct 15 '24 21:10 Andarist

tinyglobby is used by vitest

VanTanev avatar Oct 15 '24 21:10 VanTanev

I just stumbled across this PR. I thought it'd be good to mention that nx, lerna, and pnpm have switched to tinyglobby

benmccann avatar Feb 26 '25 16:02 benmccann