keystatic icon indicating copy to clipboard operation
keystatic copied to clipboard

Give groups a visual border

Open tordans opened this issue 5 months ago • 2 comments

I want to revisit the idea to add a visual indication for groups.

(…) It lacks the prominent delineation of your example, which I'd like to revisit in the future. From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

Originally posted by @jossmac in https://github.com/Thinkmill/keystatic/issues/641#issuecomment-1749974974

Current Proposal
current proposal

From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

I expect the primary use case to have one group. So IMO the UI should serve this use case first. However, if deeply nested structures are in deed something that happens a lot and the border does indeed make this case noticably worse, we could add custom CSS to only show the border on the first level. Or introduce a new flag like showGrouped: true to opt into the border.

tordans avatar Sep 01 '24 08:09 tordans