Put clearer (red dot ?) alerts when the user has something to change (a la usethis)

[ColinFay]

For example, the grey here is a little bit too clear. A red dot / square should do the trick.

[novica]

I will try to do this one next.

[ColinFay]

Hey,

I think @shahryary started to work on this in https://github.com/ThinkR-open/golem/pull/185

@shahryary, what we need here would be this — not printing in red the text, but adding a red bullet, as usethis does, for example here with the "Modify". Do you want to work on this one?

[shahryary]

Hi, @ColinFay I'm working on it.

[shahryary]

@ColinFay I modified message in golem::use_favicon() (now using red dot ) just please check it, if everything is fine then I can work on other messages. Thanks!

[ColinFay]

Mmh, so the convention in usethis is :

• The user doesn't have anything else to do => print the info with a green tick
• The user still have something to do => print the info with a red dot. I just realised the original issue was pretty unclear, sorry.

So here we would switch to

cat_rule("Change / Add in the app_ui function")
cat_line(darkgrey((glue('golem::favicon("www/favicon.{ext}")')))

to

cat_green_tick("Change / Add in the app_ui function")
cat_line(glue('golem::favicon("www/favicon.{ext}")'))

As the user has something to do: set the favicon in the app_ui

[ColinFay]

The idea with this issue is to check all the times golem prints things to the console, and check that it follows this convention :

• green tick: the user has nothing to do
• red dot: information about the fact that the user has to do something
• rule: title of the information
• line: information
• bullet: when using list in information
• cross: error

For example:

Prints a red dot in the first line when it's informative, not an action the user has to perform.

[RichardPilbery]

Is this still an issue? I see red dots EVERYWHERE?!

[ColinFay]

@RichardPilbery the red dot are mainly generated by {usethis} right now :)

The idea with this issue would be to go other the messages printed by {golem} itself and add correct information symbol/printing to the message.