Deprecate golem::add_ui_server_files()

[ColinFay]

I don't think we should keep golem::add_ui_server_files() inside {golem}.

This issue is a proposal for softly deprecating it in the next release.

Please comment below if you're using this function and are against deprecating this function.

[ColinFay]

Might be needed for https://github.com/ThinkR-open/golem/issues/693

[EwokOzwok]

I am using this function quite a bit!

[ColinFay]

Hey @EwokOzwok,

would you be ok with adding some details on when / how you're using it?

thanks

[EwokOzwok]

@ColinFay I'm using it to modify golem packages for PWA compatibility with shinyMobile:

Open ./R/app_ui.R. Scroll down to the golem_add_external_resources function. Comment out the code as shown on the left (to avoid conflicts with {shinyMobile} PWA assets). Call golem::add_ui_server_files().

Source: Slide: Road to PWA : Modify {golem} package https://rinterface.github.io/shinyMobile/articles/shinyMobile.html

Although the deeper I go, the more trouble I'm having getting shinyMobile's PWA to work in deployed docker containers. But if it's necessary to call this function to modify golem to be PWA compatible with shinyMobile I'd keep using it!

p.s. I'm not an expert if that wasn't abundantly clear :)