dockerfiler icon indicating copy to clipboard operation
dockerfiler copied to clipboard

Published 20 hours ago • verified publisher icon ThinkR-open

`dock_from_desc()` support for GitLab

Open michkam89 opened this issue 2 years ago • 1 comments

Hi,

I see that dock_from_desc() only supports CRAN and GitHub packages. I saw #16, so is it maybe planned to add GitLab as well in the near future? I would also be interested in supporting on-prem hosts here, not only gitlab.com.

If not, are you open to providing some pull requests in this matter?

Thanks!

michkam89 avatar Aug 11 '22 15:08 michkam89

Now that we use {attachment} in {golem}, we would be able to use functionalities that detects other sources, and combine with what exists in {dockerfiler}.
Some ongoing issues are listed in {attachment} in this way: https://github.com/ThinkR-open/attachment/issues
GitLab is already accounted for in attachment::find_remotes() to fill your DESCRIPTION file.
Then, sub-functions of create_dependency_file() could be used to fill this Dockerfile as described in this issue: https://github.com/ThinkR-open/attachment/issues/56

statnmap avatar Aug 11 '22 19:08 statnmap