serilog-sinks-newrelic-logs icon indicating copy to clipboard operation
serilog-sinks-newrelic-logs copied to clipboard

[feature] Update `Serilog.Sinks.PeriodicBatching` to `3.1.0`

Open NielsPilgaard opened this issue 1 year ago • 2 comments

Git Merge

Status

READY

Whats?

  • [x] Update Serilog.Sinks.PeriodicBatching to 3.1.0
  • [x] Implement IBatchedLogEventSink instead of inheriting from PeriodicBatchingSink as recommended in the README.

Why?

I'm troubleshooting an issue with dropped log messages, and having PeriodicBatchingSink up-to-date would allow me to debug more precisely, and report issues if I find any.

How?

I updated the PeriodicBatchingSink implementation to follow their current usage guidelines.

Attachments (if appropriate)

Add additional informations like screenshots, issue link, zendesk ticket link, jira task link, etc

Definition of Done:

  • [ ] Increases API documentation
  • [ ] Implements integration tests
  • [ ] Implements unit tests
  • [ ] Is there appropriate logging included?
  • [ ] Does this add new dependencies?
  • [x] Does need add new version in changelog?
  • [ ] Does need update readme, contributing, etc?
  • [ ] Does need change in CI server?
  • [ ] Will this feature require a new piece of infrastructure be implemented?
  • [ ] Does this PR require a blog post? If so, ensure marketing has signed off on content.

NielsPilgaard avatar May 25 '23 09:05 NielsPilgaard