Andreas Freund

See my comments on #499 #498 #497, this cannot be decided in silos but rather together as a cohesive framework(s). Thoughts?

something to consider -> there are significant advantages to using IPFS cluster library e.g. redundancy, MFS, and performance. However, this is only available in go, and is not compatible with...

There are two concepts here we need to distinguish and they may or may not be treated differently: 1. The state of a BPI Account which is the common agreed...

Questions: - which types of ZKP will the SRI support? - which prover system(s) will the SRI support? - will we support private trusted set-up generation or only either rely...

question: given that the SRI will probably be most commonly used to not only get started but also as the basis for company-specific implementation, are there any downsides to using...

Closing as addressed in spec

A couple of comments/thoughts/observations: - You need all contracts to be facets in the diamond pattern, not just the shield contract - You need the governance contract from the Diamond...

Trail of Bits brought up [significant security issues](https://blog.trailofbits.com/2020/10/30/good-idea-bad-design-how-the-diamond-standard-falls-short/) with EIP-2535, [and the response](https://dev.to/mudgen/addressing-josselin-feist-s-concern-s-of-eip-2535-diamond-standard-me8). [More real-world use cases and a Consensys Diligence recommendation](https://eip2535diamonds.substack.com/p/what-people-say-about-the-diamond) [Real-world use case](https://coinyuppie.com/analysis-of-eip-2535-diamond-protocol-from-the-saudis-incident/) and security analysis of that...

@MicahZoltu implemented all required changes.

@MicahZoltu ... a gentle reminder to merge if it looks ok for you. Thank you!