Thenlie
add pagination to DiscoverDetailScreen
Description
This PR tackles the enhancement request "Paginate discover details data"
@Richie911 is attempting to deploy a commit to the Streamability Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| streamability | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 11, 2025 3:37am |
If I understand this correctly, this PR does not actually paginate the discover details request. Instead, it just breaks up the pre-existing data into pages. With this approach, we do not get any performance benefits as all the data must be fetched before the UI can be rendered. If we have all the data, we should not make the user wait for it to be displayed.
Instead, we should paginate the actual request. I believe https://github.com/Thenlie/Streamability/blob/main/src/hooks/usePaginatedData.ts can be used to accomplish this. Let me know if you have any specific questions here, happy to try and help!
Going to close this out but feel free to re-open if you get this updated. Would love to get this feature in!