Theelx

Results 132 comments of Theelx

The initial comment was that 3.8 introduced support for the walrus operator was well as the ``{expr=}`` feature for f-strings. That is a true statement, see [walrus](https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions) and [expr=](https://docs.python.org/3/whatsnew/3.8.html#f-strings-support-for-self-documenting-expressions-and-debugging).

I'm not sure, could this be a bug in fasttext? I don't believe jsonpickle uses any c-extensions, so I'd be surprised if the segmentation fault was jsonpickle's fault. That said,...

I'd expect so. In my experience with ``Cython``, ``pybind``, and handwritten c-extensions, I've never seen a segmentation fault come from code that is pure-python, like jsonpickle is. If you could...

### Another Option One option I came across a few minutes ago was base 100 encoding/decoding. The example code [in a GitHub repo here](https://github.com/MasterGroosha/pybase100/blob/master/pybase100/__init__.py) looks simpler and possible more cpu-efficient...

Ok got it. The base 100 idea didn't really pan out, however I got base122 down to about **twice** as fast as base85 with Cython, and I believe the pure...

~~Oh also, shouldn't the ``encode_bytes`` param default to 'base64'? Or are you thinking something like ``encoding = encode_bytes or 'base64'``?~~ Ignore this, I missed the last paragraph of your previous...

Ok, that sounds good, I'll make sure to include that in the documentation. I'm thinking that encode_bytes will default to ``base64``, and if it's set to anything else, use that...

Thank you for the PR! Please link this issue to your PR by editing the PR description to say "Fixes #399".

> I tried pickle, pickle doesn't work in this case either. I assume jsonpickle use pickle instead of dill in nature. Is there any way to solve this problem? Thanks....

Thanks! I can't decide whether this PR should replace the other open one or if I should merge the other one first (once it works of course).